On Sat, Nov 17, 2012 at 12:05 PM, SZEDER Gábor sze...@ira.uka.de wrote:
test_expect_success 'basic' '
- run_completion git \\
+ run_completion git
I don't like this approach. I prefer
run_completion git
So that it's similar to how test_completion is called:
run_completion
To simulate that the user hit 'git TAB, the 'basic' test sets up the
rather strange command line containing the two words
git
i.e. the second word on the command line consists of two double
quotes. This is not what happens for real, however, because after
'git TAB' the second word on the
SZEDER Gábor wrote:
Fix this by passing the command line to run_completion() as separate
words.
Good catch. The change makes sense, the code looks saner after the
fix, and since this is test code any breakage should be caught
quickly, so
Reviewed-by: Jonathan Nieder jrnie...@gmail.com
3 matches
Mail list logo