Re: [PATCH 2/7] diff.c: take "prefix" argument in diff_opt_parse()

On Wed, Jan 20, 2016 at 01:49:21PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > On Wed, Jan 20, 2016 at 12:23:38PM -0800, Junio C Hamano wrote: > > > >> Nguyễn Thái Ngọc Duy writes: > >> > >> > This will be important later when diff_opt_parse()

Re: [PATCH 2/7] diff.c: take "prefix" argument in diff_opt_parse()

Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/7] diff.c: take "prefix" argument in diff_opt_parse()

Nguyễn Thái Ngọc Duy writes: > This will be important later when diff_opt_parse() accepts paths as > arguments. Paths must be prefixed before access because setup code > moves cwd but does not (and cannot) update command line options. The above sounds like a sensible thing

Re: [PATCH 2/7] diff.c: take "prefix" argument in diff_opt_parse()

On Wed, Jan 20, 2016 at 12:23:38PM -0800, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > > > This will be important later when diff_opt_parse() accepts paths as > > arguments. Paths must be prefixed before access because setup code > > moves cwd but does not (and

Re: [PATCH 2/7] diff.c: take "prefix" argument in diff_opt_parse()

Jeff King writes: > On Wed, Jan 20, 2016 at 12:23:38PM -0800, Junio C Hamano wrote: > >> Nguyễn Thái Ngọc Duy writes: >> >> > This will be important later when diff_opt_parse() accepts paths as >> > arguments. Paths must be prefixed before access because