Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

2018-07-17 Thread SZEDER Gábor
On Thu, Jul 12, 2018 at 8:35 PM Junio C Hamano wrote: > > Junio C Hamano writes: > > > Eric Sunshine writes: > > > >> On Thu, Jul 12, 2018 at 8:37 AM SZEDER Gábor wrote: > >>> The change below should be squashed into this patch to fix a > >>> previously unnoticed broken &&-chain. I think you

Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

2018-07-12 Thread Eric Sunshine
On Thu, Jul 12, 2018 at 2:50 PM Junio C Hamano wrote: > Eric Sunshine writes: > > The exact reason is that the prerequisite was not met (indeed, I > > wasn't even aware of that prerequisite), so the commit message can be > > more direct: > > > > This was missed by the previous clean-ups due

Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

2018-07-12 Thread Junio C Hamano
Eric Sunshine writes: > On Thu, Jul 12, 2018 at 2:35 PM Junio C Hamano wrote: >> Junio C Hamano writes: >> Oops, sent before completing the message. >> >> For that to happen, we need a sign-off ;-) >> >> I guess this one would have been caught with the "sed script on >> subshell"

Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

2018-07-12 Thread Eric Sunshine
On Thu, Jul 12, 2018 at 2:35 PM Junio C Hamano wrote: > Junio C Hamano writes: > Oops, sent before completing the message. > > For that to happen, we need a sign-off ;-) > > I guess this one would have been caught with the "sed script on > subshell" linter that does not execute? Yes,

Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

2018-07-12 Thread Junio C Hamano
Junio C Hamano writes: > Eric Sunshine writes: > >> On Thu, Jul 12, 2018 at 8:37 AM SZEDER Gábor wrote: >>> The change below should be squashed into this patch to fix a >>> previously unnoticed broken &&-chain. I think you missed it, because >>> this test script is rather expensive and you

Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

2018-07-12 Thread Junio C Hamano
Eric Sunshine writes: > On Thu, Jul 12, 2018 at 8:37 AM SZEDER Gábor wrote: >> The change below should be squashed into this patch to fix a >> previously unnoticed broken &&-chain. I think you missed it, because >> this test script is rather expensive and you didn't run it with >>

Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

2018-07-12 Thread Jeff King
On Thu, Jul 12, 2018 at 01:44:49PM -0400, Eric Sunshine wrote: > On Thu, Jul 12, 2018 at 8:37 AM SZEDER Gábor wrote: > > The change below should be squashed into this patch to fix a > > previously unnoticed broken &&-chain. I think you missed it, because > > this test script is rather expensive

Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

2018-07-12 Thread Eric Sunshine
On Thu, Jul 12, 2018 at 8:37 AM SZEDER Gábor wrote: > The change below should be squashed into this patch to fix a > previously unnoticed broken &&-chain. I think you missed it, because > this test script is rather expensive and you didn't run it with > GIT_TEST_CLONE_2GB=YesPlease. > > diff

Re: [PATCH 21/25] t5000-t5999: fix broken &&-chains

2018-07-12 Thread SZEDER Gábor
> Signed-off-by: Eric Sunshine > --- > t/t5300-pack-object.sh | 2 +- > t/t5302-pack-index.sh | 2 +- > t/t5401-update-hooks.sh| 4 ++-- > t/t5500-fetch-pack.sh | 2 +- > t/t5505-remote.sh | 2 +- > t/t5512-ls-remote.sh | 4 ++-- >

[PATCH 21/25] t5000-t5999: fix broken &&-chains

2018-07-01 Thread Eric Sunshine
Signed-off-by: Eric Sunshine --- t/t5300-pack-object.sh | 2 +- t/t5302-pack-index.sh | 2 +- t/t5401-update-hooks.sh| 4 ++-- t/t5500-fetch-pack.sh | 2 +- t/t5505-remote.sh | 2 +- t/t5512-ls-remote.sh | 4 ++--