Re: [PATCH 21/25] t9001: use test_when_finished

Quoting Jeff King p...@peff.net: The confirmation tests in t9001 all save the value of sendemail.confirm, do something to it, then restore it at the end, in a way that breaks the -chain (they are not wrong, because they save the $? value, but it fools --chain-lint). Instead, they can all use

Re: [PATCH 21/25] t9001: use test_when_finished

On Wed, Mar 25, 2015 at 03:00:22AM +0100, SZEDER Gábor wrote: Instead, they can all use test_when_finished, and we can even make the code simpler by factoring out the shared lines. I think that saving the value of 'sendemail.confirm' is not necessary. There are two blocks of confirmation

[PATCH 21/25] t9001: use test_when_finished

The confirmation tests in t9001 all save the value of sendemail.confirm, do something to it, then restore it at the end, in a way that breaks the -chain (they are not wrong, because they save the $? value, but it fools --chain-lint). Instead, they can all use test_when_finished, and we can even