Re: [PATCH 22/26] add_reflog_for_walk: avoid memory leak

2017-04-28 Thread Johannes Schindelin
Hi Hannes, On Thu, 27 Apr 2017, Johannes Sixt wrote: > Am 26.04.2017 um 22:21 schrieb Johannes Schindelin: > > We free()d the `log` buffer when dwim_log() returned 1, but not when it > > returned a larger value (which meant that it still allocated the buffer > > but we simply ignored it). > > >

Re: [PATCH 22/26] add_reflog_for_walk: avoid memory leak

2017-04-27 Thread Johannes Sixt
Am 26.04.2017 um 22:21 schrieb Johannes Schindelin: We free()d the `log` buffer when dwim_log() returned 1, but not when it returned a larger value (which meant that it still allocated the buffer but we simply ignored it). Identified by Coverity. Signed-off-by: Johannes Schindelin

[PATCH 22/26] add_reflog_for_walk: avoid memory leak

2017-04-26 Thread Johannes Schindelin
We free()d the `log` buffer when dwim_log() returned 1, but not when it returned a larger value (which meant that it still allocated the buffer but we simply ignored it). Identified by Coverity. Signed-off-by: Johannes Schindelin --- reflog-walk.c | 6 +- 1 file