Re: [PATCH 3/3] Change update_refs to run a single commit loop once all work is finished.

Hopefully Michael would respond with more in-depth reviews as he has been touching this area heavily recently, but a few comments. > Subject: Re: [PATCH 3/3] Change update_refs to run a single commit loop once > all work is fi The project convention is to prefix with the "", colon, SP, a sentenc

[PATCH 3/3] Change update_refs to run a single commit loop once all work is finished.

During update_refs we will both be deleting refs as well as updating/changing the refs. Since both delete and update now use the same lock/update/commit pattern lock = lock_ref_sha1_basic() (or varient of) write_ref_sha1(lock)/delete_ref_loose(lock) unlock_ref(lock) | commit_ref_lock(l