Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-19 Thread Linus Torvalds
On Mon, Mar 19, 2018, 04:34 Johannes Schindelin wrote: > > This is a real problem. No it isn't. We already handle those special cases specially, and install them in the bin directory (as opposed to libexec). And it all works fine. Look into the bin directory some

Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-19 Thread Johannes Schindelin
Hi Ævar, On Fri, 16 Mar 2018, Ævar Arnfjörð Bjarmason wrote: > > On Fri, Mar 16 2018, Johannes Schindelin jotted: > > > On Thu, 15 Mar 2018, Linus Torvalds wrote: > > > >> We do end up still using the dashed form for certain things, but they > >> are already special-cased (ie things like

Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-16 Thread Ævar Arnfjörð Bjarmason
On Fri, Mar 16 2018, Johannes Schindelin jotted: > Hi Linus. > > On Thu, 15 Mar 2018, Linus Torvalds wrote: > >> We do end up still using the dashed form for certain things, but they >> are already special-cased (ie things like "git-receive-pack" and >> "git-shell" that very much get executed

Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-16 Thread Johannes Schindelin
Hi Linus. On Thu, 15 Mar 2018, Linus Torvalds wrote: > We do end up still using the dashed form for certain things, but they > are already special-cased (ie things like "git-receive-pack" and > "git-shell" that very much get executed directly, and for fundamental > reasons). Please do

Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-15 Thread Linus Torvalds
On Thu, Mar 15, 2018 at 10:05 AM, Johannes Schindelin wrote: > The most sensible thing, of course, would be to *not* link the builtins at > all. I mean, we deprecated the dashed form (which was a design mistake, > whether you admit it or not) a long time ago. That's

Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-15 Thread Johannes Schindelin
Hi Linus, On Wed, 14 Mar 2018, Linus Torvalds wrote: > On Wed, Mar 14, 2018 at 3:14 AM, Ævar Arnfjörð Bjarmason > wrote: > > On Wed, Mar 14 2018, Johannes Sixt jotted: > >> > >> It is important to leave the default at hard-linking the binaries, > >> because on Windows symbolic

Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-15 Thread Johannes Schindelin
Hi, On Wed, 14 Mar 2018, Johannes Sixt wrote: > Am 13.03.2018 um 21:39 schrieb Ævar Arnfjörð Bjarmason: > > Add a INSTALL_SYMLINKS option which if enabled, changes the default > > hardlink installation method to one where the relevant binaries in > > libexec/git-core are symlinked back to

Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-14 Thread Linus Torvalds
On Wed, Mar 14, 2018 at 3:14 AM, Ævar Arnfjörð Bjarmason wrote: > On Wed, Mar 14 2018, Johannes Sixt jotted: >> >> It is important to leave the default at hard-linking the binaries, >> because on Windows symbolic links are second class citizens (they >> require special

Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-14 Thread Ævar Arnfjörð Bjarmason
On Wed, Mar 14 2018, Johannes Sixt jotted: > Am 13.03.2018 um 21:39 schrieb Ævar Arnfjörð Bjarmason: >> Add a INSTALL_SYMLINKS option which if enabled, changes the default >> hardlink installation method to one where the relevant binaries in >> libexec/git-core are symlinked back to ../../bin,

Re: [PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-14 Thread Johannes Sixt
Am 13.03.2018 um 21:39 schrieb Ævar Arnfjörð Bjarmason: Add a INSTALL_SYMLINKS option which if enabled, changes the default hardlink installation method to one where the relevant binaries in libexec/git-core are symlinked back to ../../bin, instead of being hardlinked. This new option also

[PATCH 3/3] Makefile: optionally symlink libexec/git-core binaries to bin/git

2018-03-13 Thread Ævar Arnfjörð Bjarmason
Add a INSTALL_SYMLINKS option which if enabled, changes the default hardlink installation method to one where the relevant binaries in libexec/git-core are symlinked back to ../../bin, instead of being hardlinked. This new option also overrides the behavior of the existing NO_*_HARDLINKS