Re: [PATCH 3/3] blame: output porcelain "previous" header for each file

2017-03-27 Thread Jeff King
On Mon, Mar 27, 2017 at 11:08:08PM +0200, Ævar Arnfjörð Bjarmason wrote: > On Fri, Jan 6, 2017 at 5:20 AM, Jeff King wrote: > > > +for output in porcelain line-porcelain > > +do > > + test_expect_success "generate --$output output" ' > > + git blame --root -C

Re: [PATCH 3/3] blame: output porcelain "previous" header for each file

2017-03-27 Thread Ævar Arnfjörð Bjarmason
On Fri, Jan 6, 2017 at 5:20 AM, Jeff King wrote: > +for output in porcelain line-porcelain > +do > + test_expect_success "generate --$output output" ' > + git blame --root -C --$output combined >output > + ' > + The --root option isn't needed here, the

Re: [PATCH 3/3] blame: output porcelain "previous" header for each file

2017-01-09 Thread Junio C Hamano
Jeff King writes: > /* > + * Write out any suspect information which depends on the path. This must be > + * handled separately from emit_one_suspect_detail(), because a given commit > + * may have changes in multiple paths. So this needs to appear each time > + * we mention a

[PATCH 3/3] blame: output porcelain "previous" header for each file

2017-01-05 Thread Jeff King
It's possible for content currently found in one file to have originated in two separate files, each of which may have been modified in some single older commit. The --porcelain output generates an incorrect "previous" header in this case, whereas --line-porcelain gets it right. The problem is