Re: [PATCH 3/3] commit-graph: lazy-load trees

2018-04-03 Thread Stefan Beller
>>> +/* >>> + * For performance reasons, a commit loaded from the graph does not >>> + * have a tree loaded until trying to consume it for the first time. >> >> That is the theme of this series/patch, but do we need to write it down >> into the codebase? I'd be inclined to omit this part and only

Re: [PATCH 3/3] commit-graph: lazy-load trees

2018-04-03 Thread Derrick Stolee
On 4/3/2018 2:00 PM, Stefan Beller wrote: On Tue, Apr 3, 2018 at 5:00 AM, Derrick Stolee wrote: The commit-graph file provides quick access to commit data, including the OID of the root tree for each commit in the graph. When performing a deep commit-graph walk, we may

Re: [PATCH 3/3] commit-graph: lazy-load trees

2018-04-03 Thread Stefan Beller
On Tue, Apr 3, 2018 at 5:00 AM, Derrick Stolee wrote: > The commit-graph file provides quick access to commit data, including > the OID of the root tree for each commit in the graph. When performing > a deep commit-graph walk, we may not need to load most of the trees > for

[PATCH 3/3] commit-graph: lazy-load trees

2018-04-03 Thread Derrick Stolee
The commit-graph file provides quick access to commit data, including the OID of the root tree for each commit in the graph. When performing a deep commit-graph walk, we may not need to load most of the trees for these commits. Delay loading the tree object for a commit loaded from the graph