Re: [PATCH 3/3] ls-tree: add unit tests for arguments

On Mon, Jul 2, 2018 at 11:58 PM Joshua Nelson wrote: > Signed-off-by: Joshua Nelson > --- > diff --git t/t3104-ls-tree-optional-args.sh t/t3104-ls-tree-optional-args.sh > @@ -0,0 +1,43 @@ > +test_expect_success 'initial setup' ' > +echo hi > test && cp test test2 && git add test test2 && git comm

Re: [PATCH 3/3] ls-tree: add unit tests for arguments

Hi Joshua, On Mon, Jul 2, 2018 at 8:58 PM, Joshua Nelson wrote: The commit message could use some clarification; it currently makes the reader think you're testing all arguments of ls-tree, when you're only testing a few new ones. Alternatively, you could squash this with patch 1. > Signed-off

[PATCH 3/3] ls-tree: add unit tests for arguments

Signed-off-by: Joshua Nelson --- t/t3104-ls-tree-optional-args.sh | 43 1 file changed, 43 insertions(+) create mode 100644 t/t3104-ls-tree-optional-args.sh diff --git t/t3104-ls-tree-optional-args.sh t/t3104-ls-tree-optional-args.sh new file mode 100644 index 0