Re: [PATCH 3/3] subtree: adjust style to match CodingGuidelines

2016-07-26 Thread Junio C Hamano
Johannes Sixt writes: > These caught my eye browsing through my inbox. I'm not a subtree user. All good comments. Let's queue 1/3 and 2/3 and fast-track them down to 'master'. Style fixes can come independently later. Thanks. > Am 26.07.2016 um 06:14 schrieb David Aguilar: >> @@ -50,87 +51,1

Re: [PATCH 3/3] subtree: adjust style to match CodingGuidelines

2016-07-25 Thread Johannes Sixt
These caught my eye browsing through my inbox. I'm not a subtree user. Am 26.07.2016 um 06:14 schrieb David Aguilar: @@ -50,87 +51,145 @@ prefix= debug() { - if [ -n "$debug" ]; then - printf "%s\n" "$*" >&2 + if test -n "$debug" + then + printf "

[PATCH 3/3] subtree: adjust style to match CodingGuidelines

2016-07-25 Thread David Aguilar
Prefer "test" over "[ ... ]", use double-quotes around variables, break long lines, and properly indent "case" statements. Signed-off-by: David Aguilar --- contrib/subtree/git-subtree.sh | 544 ++--- 1 file changed, 341 insertions(+), 203 deletions(-) diff --