Felipe Contreras wrote:
This is what Linux's checkpatch throws:
Perhaps it's time to include checkpatch.pl in our tree and update our
CodingGuidelines?
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Fri, May 17, 2013 at 11:22 AM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
*You* are telling my that; it's *your* opinion and nothing else. It's
I saw a review comment that points out that the continuation lines
do not align, and you refused
Felipe Contreras felipe.contre...@gmail.com writes:
THERE IS NO STYLE BREAKAGE.
Repeating something, and even making it all caps does not make it true.
You are wasting your time and everybody else's in this thread and many
others. You seem to reject the very concept of code review. The Git
On Fri, May 17, 2013 at 11:56 AM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
THERE IS NO STYLE BREAKAGE.
Repeating something, and even making it all caps does not make it true.
Tell that to Junio. He is also repeating the same.
I
Felipe Contreras felipe.contre...@gmail.com writes:
On Fri, May 17, 2013 at 11:56 AM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
THERE IS NO STYLE BREAKAGE.
Repeating something, and even making it all caps does not make it true.
On Fri, May 17, 2013 at 12:14 PM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
On Fri, May 17, 2013 at 11:56 AM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
THERE IS NO STYLE
On Thu, May 9, 2013 at 6:12 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
On Thu, May 9, 2013 at 6:09 PM, Junio C Hamano gits...@pobox.com wrote:
John Szakmeister j...@szakmeister.net writes:
On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
I find it extremely annoying that an obviously correct patch is not
merged...
A patch that receives this breaks style comments and its author
stubbornly refusing to fix what others pointed out, especially when
the patch itself _is_ about
On Thu, May 16, 2013 at 11:49 AM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
I find it extremely annoying that an
On Thu, May 16, 2013 at 6:54 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
There are 535 instances where parenthesis are not aligned. Do you
still think aligning open parenthesis is the style of the project?
Please. You are rejecting this patch on a whim, and nothing more.
And FTR.
On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
builtin/fast-export.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/builtin/fast-export.c
On Thu, May 9, 2013 at 3:46 AM, John Szakmeister j...@szakmeister.net wrote:
On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
builtin/fast-export.c | 24
1 file changed,
Felipe Contreras wrote:
AFAIK neither the git or the Linux code-style specify how multiple
lines with open parenthesis should align.
git style inherits from linux style. See Chapter 9 of
Documentation/CodingStyle in linux.git. It has elisp snippets you can
stick in your .emacs.
--
To
On Thu, May 9, 2013 at 5:24 AM, Ramkumar Ramachandra artag...@gmail.com wrote:
Felipe Contreras wrote:
AFAIK neither the git or the Linux code-style specify how multiple
lines with open parenthesis should align.
git style inherits from linux style. See Chapter 9 of
Documentation/CodingStyle
Felipe Contreras felipe.contre...@gmail.com writes:
if (!author)
- die (Could not find author in commit %s,
+ die(Could not find author in commit %s,
sha1_to_hex(commit-object.sha1));
It looks like your simple replace didn't account
On Thu, May 9, 2013 at 1:38 PM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
if (!author)
- die (Could not find author in commit %s,
+ die(Could not find author in commit %s,
John Szakmeister j...@szakmeister.net writes:
On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
builtin/fast-export.c | 24
1 file changed, 12 insertions(+), 12
On Thu, May 9, 2013 at 6:09 PM, Junio C Hamano gits...@pobox.com wrote:
John Szakmeister j...@szakmeister.net writes:
On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
builtin/fast-export.c | 24
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
builtin/fast-export.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/builtin/fast-export.c b/builtin/fast-export.c
index d60d675..8091354 100644
--- a/builtin/fast-export.c
+++
19 matches
Mail list logo
