Re: [PATCH 3/4] Makefile: use the sha1collisiondetection submodule by default

2017-12-09 Thread Kevin Daudt
On Sat, Dec 09, 2017 at 01:30:14PM +0100, Kevin Daudt wrote: > On Tue, Dec 05, 2017 at 02:02:50AM -0500, Jeff King wrote: > > On Tue, Nov 28, 2017 at 09:32:13PM +, Ævar Arnfjörð Bjarmason wrote: > > > > > Change the build process so that instead of needing to supply > > >

Re: [PATCH 3/4] Makefile: use the sha1collisiondetection submodule by default

2017-12-09 Thread Kevin Daudt
On Tue, Dec 05, 2017 at 02:02:50AM -0500, Jeff King wrote: > On Tue, Nov 28, 2017 at 09:32:13PM +, Ævar Arnfjörð Bjarmason wrote: > > > Change the build process so that instead of needing to supply > > DC_SHA1_SUBMODULE=YesPlease to use the sha1collisiondetection > > submodule instead of the

Re: [PATCH 3/4] Makefile: use the sha1collisiondetection submodule by default

2017-12-05 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Change the build process so that instead of needing to supply > DC_SHA1_SUBMODULE=YesPlease to use the sha1collisiondetection > submodule instead of the copy of the same code shipped in the sha1dc > directory, it uses the submodule by default

Re: [PATCH 3/4] Makefile: use the sha1collisiondetection submodule by default

2017-12-05 Thread Ævar Arnfjörð Bjarmason
On Tue, Dec 05 2017, Junio C. Hamano jotted: > Ævar Arnfjörð Bjarmason writes: > >>> I'm not sure how I feel about this. I see your point that there's no >>> real value in maintaining two systems indefinitely. At the same time, I >>> wonder how much value the submodule

Re: [PATCH 3/4] Makefile: use the sha1collisiondetection submodule by default

2017-12-05 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> I'm not sure how I feel about this. I see your point that there's no >> real value in maintaining two systems indefinitely. At the same time, I >> wonder how much value the submodule strategy is actually bringing us. >> >> IOW, are we agreed

Re: [PATCH 3/4] Makefile: use the sha1collisiondetection submodule by default

2017-12-05 Thread Ævar Arnfjörð Bjarmason
[Forgot to CC Stefan & Brandon who were involved in previous discussions] On Tue, Dec 05 2017, Jeff King jotted: > On Tue, Nov 28, 2017 at 09:32:13PM +, Ævar Arnfjörð Bjarmason wrote: > >> Change the build process so that instead of needing to supply >> DC_SHA1_SUBMODULE=YesPlease to use

Re: [PATCH 3/4] Makefile: use the sha1collisiondetection submodule by default

2017-12-04 Thread Jeff King
On Tue, Nov 28, 2017 at 09:32:13PM +, Ævar Arnfjörð Bjarmason wrote: > Change the build process so that instead of needing to supply > DC_SHA1_SUBMODULE=YesPlease to use the sha1collisiondetection > submodule instead of the copy of the same code shipped in the sha1dc > directory, it uses the

[PATCH 3/4] Makefile: use the sha1collisiondetection submodule by default

2017-11-28 Thread Ævar Arnfjörð Bjarmason
Change the build process so that instead of needing to supply DC_SHA1_SUBMODULE=YesPlease to use the sha1collisiondetection submodule instead of the copy of the same code shipped in the sha1dc directory, it uses the submodule by default unless NO_DC_SHA1_SUBMODULE=UnfortunatelyYes is supplied.