Re: [PATCH 3/4] line-log: optimize ranges by joining them when possible

2018-08-05 Thread Eric Sunshine
> On 2018-08-05 00:18, Johannes Schindelin via GitGitGadget wrote: > > Technically, it is okay to have line ranges that touch (i.e. the end of > > the first range ends just before the next range begins). However, it is > > inefficient, and when the user provides such touching ranges via > >

Re: [PATCH 3/4] line-log: optimize ranges by joining them when possible

2018-08-05 Thread Andrei Rybak
On 2018-08-05 00:18, Johannes Schindelin via GitGitGadget wrote: > > Now, I am fairly certain that the changes are correct, but given my track > record with off-by-one bugs (and once even an off-by-two bug), I would > really appreciate some thorough review of this code, in particular the > second

Re: [PATCH 3/4] line-log: optimize ranges by joining them when possible

2018-08-05 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > Technically, it is okay to have line ranges that touch (i.e. the end of > the first range ends just before the next range begins). However, it is > inefficient, and when the user provides such touching ranges via >

[PATCH 3/4] line-log: optimize ranges by joining them when possible

2018-08-04 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Technically, it is okay to have line ranges that touch (i.e. the end of the first range ends just before the next range begins). However, it is inefficient, and when the user provides such touching ranges via multiple `-L` options, we already join them. When we