Le mercredi 3 mai 2017, 10:04:01 CEST Jonathan Nieder a écrit :
> Hi,
>
> Jean-Noel Avila wrote:
> > Subject: read-tree.c: rework UI when merging no trees
>
> nit: this is about user-facing behavior, not an implementation detail,
> so the part before the colon can be the command that changed
>
Hi,
Jean-Noel Avila wrote:
> Subject: read-tree.c: rework UI when merging no trees
nit: this is about user-facing behavior, not an implementation detail,
so the part before the colon can be the command that changed
(read-tree:).
nit: the word "rework" is dangerous in a commit message in the
The initial test was inherited from a previous commit, but it is no
longer needed, given the following switch case. Moreover, the question
sentence ending the program has been replace by an assertative one.
Signed-off-by: Jean-Noel Avila
---
builtin/read-tree.c | 5 +++--
1
3 matches
Mail list logo