Re: [PATCH 3/4] status: give more information during rebase -i

2015-06-09 Thread Guillaume Pages
Junio C Hamano gits...@pobox.com writes: Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr writes: git status gives more information during rebase -i, about the list of command that are done during the rebase. It displays the two last commands executed and the two next lines to be

[PATCH 3/4] status: give more information during rebase -i

2015-06-09 Thread Guillaume Pagès
git status gives more information during rebase -i, about the list of command that are done during the rebase. It displays the two last commands executed and the two next lines to be executed. It also gives hints to find the whole files in .git directory. Signed-off-by: Guillaume Pagès

Re: [PATCH 3/4] status: give more information during rebase -i

2015-06-08 Thread Junio C Hamano
Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr writes: git status gives more information during rebase -i, about the list of command that are done during the rebase. It displays the two last commands executed and the two next lines to be executed. It also gives hints to find the

[PATCH 3/4] status: give more information during rebase -i

2015-06-08 Thread Guillaume Pagès
git status gives more information during rebase -i, about the list of command that are done during the rebase. It displays the two last commands executed and the two next lines to be executed. It also gives hints to find the whole files in .git directory. --- I've applied your remarks, the way to

Re: [PATCH 3/4] status: give more information during rebase -i

2015-06-08 Thread Matthieu Moy
Please, include a version number in the subject. git send-email -v2 does this for you. Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr writes: +static void show_rebase_information(struct wt_status *s, + struct wt_status_state *state, +

Re: [PATCH 3/4] status: give more information during rebase -i

2015-06-05 Thread Junio C Hamano
Guillaume Pages guillaume.pa...@ensimag.grenoble-inp.fr writes: I felt that was not the right way to do so. What do you think of a function like that: /* * Puts nb_commands commands from filename in lines, * returns the total number of commands in the file * ignores comments and empty

Re: [PATCH 3/4] status: give more information during rebase -i

2015-06-05 Thread Guillaume Pages
Junio C Hamano gits...@pobox.com writes Matthieu Moy matthieu@grenoble-inp.fr writes: +void get_two_last_lines(char *filename, int *numlines, char **lines) +{ +... +} + +void get_two_first_lines(char *filename, int *numlines, char **lines) +{ +... +} I had a handful of

Re: [PATCH 3/4] status: give more information during rebase -i

2015-06-04 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: +void get_two_last_lines(char *filename, int *numlines, char **lines) +{ +... +} + +void get_two_first_lines(char *filename, int *numlines, char **lines) +{ +... +} I had a handful of comments on these: - Do we need two separate and

Re: [PATCH 3/4] status: give more information during rebase -i

2015-06-04 Thread Matthieu Moy
Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr writes: + (use git rebase --edit-todo to view and edit) You're still missing double-quotes around git rebase --edit-todo. Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr writes: +Last command(s) done (1 command(s) done): Can't

[PATCH 3/4] status: give more information during rebase -i

2015-06-03 Thread Guillaume Pagès
git status gives more information during rebase -i, about the list of command that are done during the rebase. It displays the two last commands executed and the two next lines to be executed. It also gives hints to find the whole files in .git directory. --- t/t7512-status-help.sh | 111