Re: [PATCH 3/4] t7800: modernize tests

2013-02-17 Thread Jonathan Nieder
David Aguilar wrote: --- a/t/t7800-difftool.sh +++ b/t/t7800-difftool.sh @@ -10,29 +10,11 @@ Testing basic diff tool invocation [...] -restore_test_defaults() -{ - # Restores the test defaults used by several tests - remove_config_vars - unset GIT_DIFF_TOOL - unset

[PATCH 3/4] t7800: modernize tests

2013-02-15 Thread David Aguilar
Eliminate a lot of redundant work by using test_config(). Chain everything together by using sane_unset() and a simpler difftool_test_setup(). The original tests relied upon restore_test_defaults() from the previous test to provide the next test with a sane environment. Make the tests do their