Re: [PATCH 3/4 v6] cache-tree: subdirectory tests

2014-07-13 Thread Junio C Hamano
David Turner dtur...@twopensource.com writes: On Fri, 2014-07-11 at 08:40 -0700, Junio C Hamano wrote: In the ideal world, I think whoever tries to compare two cache-trees (i.e. test-dump-cache-tree) should *not* care, because we are merely trying to show what the correct tree object name

Re: [PATCH 3/4 v6] cache-tree: subdirectory tests

2014-07-11 Thread Eric Sunshine
On Thu, Jul 10, 2014 at 8:31 PM, David Turner dtur...@twopensource.com wrote: Add tests to confirm that invalidation of subdirectories neither over- nor under-invalidates. Signed-off-by: David Turner dtur...@twitter.com --- t/t0090-cache-tree.sh | 26 +++--- 1 file

Re: [PATCH 3/4 v6] cache-tree: subdirectory tests

2014-07-11 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: On Thu, Jul 10, 2014 at 8:31 PM, David Turner dtur...@twopensource.com wrote: Add tests to confirm that invalidation of subdirectories neither over- nor under-invalidates. Signed-off-by: David Turner dtur...@twitter.com ---

Re: [PATCH 3/4 v6] cache-tree: subdirectory tests

2014-07-11 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: + sed -n -e s/[0-9]* subtrees// -e '/#(ref)/d' -e '/^invalid /p' actual Is the second one to remove #(ref), which appears for a good reference cache tree entry shown for comparison, necessary? Do they ever begin with invalid? If they ever

Re: [PATCH 3/4 v6] cache-tree: subdirectory tests

2014-07-11 Thread David Turner
On Fri, 2014-07-11 at 08:40 -0700, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: + sed -n -e s/[0-9]* subtrees// -e '/#(ref)/d' -e '/^invalid /p' actual Is the second one to remove #(ref), which appears for a good reference cache tree entry shown for

Re: [PATCH 3/4 v6] cache-tree: subdirectory tests

2014-07-11 Thread David Turner
On Fri, 2014-07-11 at 08:27 -0700, Junio C Hamano wrote: Eric Sunshine sunsh...@sunshineco.com writes: On Thu, Jul 10, 2014 at 8:31 PM, David Turner dtur...@twopensource.com wrote: Add tests to confirm that invalidation of subdirectories neither over- nor under-invalidates.

[PATCH 3/4 v6] cache-tree: subdirectory tests

2014-07-10 Thread David Turner
Add tests to confirm that invalidation of subdirectories neither over- nor under-invalidates. Signed-off-by: David Turner dtur...@twitter.com --- t/t0090-cache-tree.sh | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/t/t0090-cache-tree.sh