Re: [PATCH 3/5] verify_lock(): report errors via a strbuf

2015-05-27 Thread Michael Haggerty
On 05/27/2015 09:48 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> Instead of writing error messages directly to stderr, write them to a >> "strbuf *err". In lock_ref_sha1_basic(), arrange for these errors to >> be returned to its caller. > > I had to scratch my head and view long out

Re: [PATCH 3/5] verify_lock(): report errors via a strbuf

2015-05-27 Thread Junio C Hamano
Michael Haggerty writes: > Instead of writing error messages directly to stderr, write them to a > "strbuf *err". In lock_ref_sha1_basic(), arrange for these errors to > be returned to its caller. I had to scratch my head and view long outside the context before realizing that the caller lock_re

[PATCH 3/5] verify_lock(): report errors via a strbuf

2015-05-22 Thread Michael Haggerty
Instead of writing error messages directly to stderr, write them to a "strbuf *err". In lock_ref_sha1_basic(), arrange for these errors to be returned to its caller. Signed-off-by: Michael Haggerty --- refs.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git