On Sat, May 14, 2016 at 10:37:07AM -0700, Junio C Hamano wrote:
> Thanks for sharp eyes. Let's squash this in, perhaps?
>
> t/t9107-git-svn-migrate.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t9107-git-svn-migrate.sh b/t/t9107-git-svn-migrate.sh
> index 29
Jeff King writes:
> On Fri, May 13, 2016 at 07:45:42PM -0400, Eric Sunshine wrote:
>
>> > + >expect &&
>>
>> What's this 'expect' file for? Is it leftover gunk from before you
>> settled on 'diff --exit-code'?
>
> Oops, yes, that's exactly it.
>
> -Peff
Thanks for sharp eyes. Let's squas
On Fri, May 13, 2016 at 07:45:42PM -0400, Eric Sunshine wrote:
> > + >expect &&
>
> What's this 'expect' file for? Is it leftover gunk from before you
> settled on 'diff --exit-code'?
Oops, yes, that's exactly it.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
On Fri, May 13, 2016 at 4:47 PM, Jeff King wrote:
> When a test runs a loop, it cannot rely on the usual
> &&-chaining to propagate a failure inside the loop; it needs
> to break out with a failure signal. However, unless you are
> in a subshell, doing so with "exit 1" will exit the entire
> test
Jeff King wrote:
> + git diff --exit-code refs/remotes/origin/$i
> refs/remotes/origin/$j ||
> + return 1
80 columns; but I guess Junio picked it up, already.
Otherwise the rest of the series looks good. Thanks.
--
To unsubscribe from this list: s
When a test runs a loop, it cannot rely on the usual
&&-chaining to propagate a failure inside the loop; it needs
to break out with a failure signal. However, unless you are
in a subshell, doing so with "exit 1" will exit the entire
test script, not just the test snippet we are in (and cause
the ha
6 matches
Mail list logo
