Re: [PATCH 3/8] Better Error Handling for add

2013-01-01 Thread Junio C Hamano
David A. Greene gree...@obbligato.org writes: From: David A. Greene gree...@obbligato.org Check refspecs for validity before passing them on to other commands. This lets us generate more helpful error messages. Signed-off-by: David A. Greene gree...@obbligato.org ---

Re: [PATCH 3/8] Better Error Handling for add

2013-01-01 Thread greened
Junio C Hamano gits...@pobox.com writes: diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh index 7ceb413..b8a807a 100755 --- a/contrib/subtree/git-subtree.sh +++ b/contrib/subtree/git-subtree.sh @@ -509,8 +509,20 @@ cmd_add() ensure_clean if [ $#

Re: [PATCH 3/8] Better Error Handling for add

2013-01-01 Thread Junio C Hamano
gree...@obbligato.org writes: If you want to make sure you give a comit to add_commit, you can probably say something like this: git rev-parse -q --verify $1^{commit} /dev/null || die '$1' does not refer to a commit What does $1^{commit} mean? $thing^{type} tells Git to

[PATCH 3/8] Better Error Handling for add

2012-12-31 Thread David A. Greene
From: David A. Greene gree...@obbligato.org Check refspecs for validity before passing them on to other commands. This lets us generate more helpful error messages. Signed-off-by: David A. Greene gree...@obbligato.org --- contrib/subtree/git-subtree.sh | 12 1 file changed, 12