Re: [PATCH 3/8] Convert struct ref to use object_id.

2015-06-11 Thread Michael Haggerty
I visually inspected patches 1 and 2 without finding any problems. Regarding this patch, I saw a few functions where you could convert local variables to struct object_id and then change function calls like hashcpy() to oidcpy(). See below. I'm not sure if it makes sense to do that in this same

[PATCH 3/8] Convert struct ref to use object_id.

2015-06-09 Thread brian m. carlson
Use struct object_id in three fields in struct ref and convert all the necessary places that use it. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- builtin/clone.c| 16 +++--- builtin/fetch-pack.c | 4 ++-- builtin/fetch.c| 50