On Fri, Mar 21, 2014 at 12:41 AM, Junio C Hamano gits...@pobox.com wrote:
Why even include cache.h for S_IXUSR?
In the context of the patch I see S_ISGID mentioned and other S_*
st_mode things are already in use in this function before this step,
and presumably you are using them without
git-compat-util.h does not seem to carry S_IXUGO. Anyway as far as Git
is concerned, we only care one executable bit. Hard code it.
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
---
ls_colors.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/ls_colors.c
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:
git-compat-util.h does not seem to carry S_IXUGO. Anyway as far as Git
is concerned, we only care one executable bit. Hard code it.
Why not use S_IXUSR instead of a hardcoded value? (already used in
path.c, so shouldn't be a problem wrt
On Thu, Mar 20, 2014 at 6:46 PM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:
git-compat-util.h does not seem to carry S_IXUGO. Anyway as far as Git
is concerned, we only care one executable bit. Hard code it.
Why not use S_IXUSR instead of
Duy Nguyen pclo...@gmail.com writes:
On Thu, Mar 20, 2014 at 6:46 PM, Matthieu Moy
matthieu@grenoble-inp.fr wrote:
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:
git-compat-util.h does not seem to carry S_IXUGO. Anyway as far as Git
is concerned, we only care one executable bit. Hard
5 matches
Mail list logo