[PATCH 3/8] pathspec: change PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE flag

2017-05-09 Thread Brandon Williams
It's confusing to have two different 'strip submodule slash' flags which do subtly different things. Both PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE and PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAP will accomplish the same task of striping a slash from a pathspec which matches a submodule entry in the index

Re: [PATCH 3/8] pathspec: change PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE flag

2017-05-09 Thread Junio C Hamano
Brandon Williams writes: > It's confusing to have two different 'strip submodule slash' flags which > do subtly different things. Both > PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE and > PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAP will accomplish the same task of > striping a slash from a pathspec which m

Re: [PATCH 3/8] pathspec: change PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE flag

2017-05-10 Thread Brandon Williams
On 05/10, Junio C Hamano wrote: > Brandon Williams writes: > > > It's confusing to have two different 'strip submodule slash' flags which > > do subtly different things. Both > > PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE and > > PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAP will accomplish the same task o