Re: [PATCH 4/2] t5615-alternate-env: double-quotes in file names do not work on Windows

2016-12-22 Thread Jeff King
On Thu, Dec 22, 2016 at 08:06:02PM +0100, Johannes Sixt wrote: > Am 22.12.2016 um 07:13 schrieb Johannes Sixt: > > Am 21.12.2016 um 23:42 schrieb Jeff King: > > > Hmph. I explicitly avoided a colon in the filename so that it would run > > > on MINGW. Is a double-quote also not allowed? > > > >

Re: [PATCH 4/2] t5615-alternate-env: double-quotes in file names do not work on Windows

2016-12-22 Thread Johannes Schindelin
Hi Hannes, On Thu, 22 Dec 2016, Johannes Sixt wrote: > Am 22.12.2016 um 07:13 schrieb Johannes Sixt: > > Am 21.12.2016 um 23:42 schrieb Jeff King: > > > Hmph. I explicitly avoided a colon in the filename so that it would > > > run on MINGW. Is a double-quote also not allowed? > > > > It is not

Re: [PATCH 4/2] t5615-alternate-env: double-quotes in file names do not work on Windows

2016-12-22 Thread Johannes Sixt
Am 22.12.2016 um 07:13 schrieb Johannes Sixt: Am 21.12.2016 um 23:42 schrieb Jeff King: Hmph. I explicitly avoided a colon in the filename so that it would run on MINGW. Is a double-quote also not allowed? It is not allowed; that was my conclusion. But now that you ask, I'll double-check.

Re: [PATCH 4/2] t5615-alternate-env: double-quotes in file names do not work on Windows

2016-12-21 Thread Johannes Sixt
Am 21.12.2016 um 23:42 schrieb Jeff King: On Wed, Dec 21, 2016 at 10:33:43PM +0100, Johannes Sixt wrote: Protect a recently added test case with !MINGW. Signed-off-by: Johannes Sixt --- I don't remember why I did not notice this failure sooner. Perhaps I did, but then ran

Re: [PATCH 4/2] t5615-alternate-env: double-quotes in file names do not work on Windows

2016-12-21 Thread Jeff King
On Wed, Dec 21, 2016 at 10:33:43PM +0100, Johannes Sixt wrote: > Protect a recently added test case with !MINGW. > > Signed-off-by: Johannes Sixt > --- > I don't remember why I did not notice this failure sooner. > Perhaps I did, but then ran out of time to debug it... > >

[PATCH 4/2] t5615-alternate-env: double-quotes in file names do not work on Windows

2016-12-21 Thread Johannes Sixt
Protect a recently added test case with !MINGW. Signed-off-by: Johannes Sixt --- I don't remember why I did not notice this failure sooner. Perhaps I did, but then ran out of time to debug it... The patch should go on top of jk/quote-env-path-list-component.