Re: [PATCH 4/3] Makefile: untangle DEVELOPER and -Werror

2018-04-07 Thread Ævar Arnfjörð Bjarmason
On Sat, Apr 07 2018, Duy Nguyen wrote: > On Sat, Apr 7, 2018 at 2:36 PM, Ævar Arnfjörð Bjarmason > wrote: >> Anyway, I see you've pushed a new version with DEVOPTS. I'll submit mine >> on top of that once your new version lands (unless you want to try to >> integrate it

Re: [PATCH 4/3] Makefile: untangle DEVELOPER and -Werror

2018-04-07 Thread Duy Nguyen
On Sat, Apr 7, 2018 at 2:36 PM, Ævar Arnfjörð Bjarmason wrote: > Anyway, I see you've pushed a new version with DEVOPTS. I'll submit mine > on top of that once your new version lands (unless you want to try to > integrate it yourself). Actually I think I'll just drop both

Re: [PATCH 4/3] Makefile: untangle DEVELOPER and -Werror

2018-04-07 Thread Ævar Arnfjörð Bjarmason
On Sat, Apr 07 2018, Duy Nguyen wrote: > On Fri, Apr 6, 2018 at 11:42 PM, Jeff King wrote: >> On Tue, Apr 03, 2018 at 05:17:00PM +0200, Duy Nguyen wrote: >> >>> It's not that complex. With the EAGER_DEVELOPER patch removed, we can >>> have something like this where eager devs

Re: [PATCH 4/3] Makefile: untangle DEVELOPER and -Werror

2018-04-07 Thread Duy Nguyen
On Fri, Apr 6, 2018 at 11:42 PM, Jeff King wrote: > On Tue, Apr 03, 2018 at 05:17:00PM +0200, Duy Nguyen wrote: > >> It's not that complex. With the EAGER_DEVELOPER patch removed, we can >> have something like this where eager devs just need to put >> >> DEVOPTS = gentle

Re: [PATCH 4/3] Makefile: untangle DEVELOPER and -Werror

2018-04-06 Thread Jeff King
On Tue, Apr 03, 2018 at 05:17:00PM +0200, Duy Nguyen wrote: > It's not that complex. With the EAGER_DEVELOPER patch removed, we can > have something like this where eager devs just need to put > > DEVOPTS = gentle no-suppression > > and you put > > DEVOPTS = gentle > > (bad naming, I

Re: [PATCH 4/3] Makefile: untangle DEVELOPER and -Werror

2018-04-03 Thread Duy Nguyen
On Tue, Apr 03, 2018 at 11:19:46AM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Sat, Mar 31 2018, Duy Nguyen wrote: > > > On Sat, Mar 31, 2018 at 6:40 PM, Ævar Arnfjörð Bjarmason > > wrote: > >> Change the DEVELOPER flag, and the newly added EAGER_DEVELOPER flag > >> which

Re: [PATCH 4/3] Makefile: untangle DEVELOPER and -Werror

2018-04-03 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 31 2018, Duy Nguyen wrote: > On Sat, Mar 31, 2018 at 6:40 PM, Ævar Arnfjörð Bjarmason > wrote: >> Change the DEVELOPER flag, and the newly added EAGER_DEVELOPER flag >> which (approximately) enables -Wextra so that any combination of them >> and -Werror can be set.

Re: [PATCH 4/3] Makefile: untangle DEVELOPER and -Werror

2018-03-31 Thread Duy Nguyen
On Sat, Mar 31, 2018 at 6:40 PM, Ævar Arnfjörð Bjarmason wrote: > Change the DEVELOPER flag, and the newly added EAGER_DEVELOPER flag > which (approximately) enables -Wextra so that any combination of them > and -Werror can be set. > > I've long wanted to use DEVELOPER=1 in my

[PATCH 4/3] Makefile: untangle DEVELOPER and -Werror

2018-03-31 Thread Ævar Arnfjörð Bjarmason
Change the DEVELOPER flag, and the newly added EAGER_DEVELOPER flag which (approximately) enables -Wextra so that any combination of them and -Werror can be set. I've long wanted to use DEVELOPER=1 in my production builds, but on some old systems I still get warnings, and thus the build would