Re: [PATCH 4/4] bisect: add the terms old/new

2015-06-10 Thread Matthieu Moy
Antoine Delaite antoine.dela...@ensimag.grenoble-inp.fr writes: Hi, thanks for the review, (sorry if you received this twice) Junio C Hamano gits...@pobox.com writes: Just throwing a suggestion. You could perhaps add a new verb to be used before starting to do anything, e.g. $ git

[PATCH 4/4] bisect: add the terms old/new

2015-06-10 Thread Antoine Delaite
Hi, thanks for the review, (sorry if you received this twice) Junio C Hamano gits...@pobox.com writes: Just throwing a suggestion. You could perhaps add a new verb to be used before starting to do anything, e.g. $ git bisect terms new old Yes it would be nice and should not be hard

Re: [PATCH 4/4] bisect: add the terms old/new

2015-06-10 Thread Christian Couder
On Wed, Jun 10, 2015 at 5:24 PM, Junio C Hamano gits...@pobox.com wrote: Matthieu Moy matthieu@grenoble-inp.fr writes: Somebody else did it like that is not a good justification. Especially when the previous code was not merged: the code wasn't finished. But I actually disagree with the

Re: [PATCH 4/4] bisect: add the terms old/new

2015-06-10 Thread Junio C Hamano
Christian Couder christian.cou...@gmail.com writes: On Wed, Jun 10, 2015 at 5:24 PM, Junio C Hamano gits...@pobox.com wrote: Matthieu Moy matthieu@grenoble-inp.fr writes: Moving from one hardcoded pair of terms to two hardcoded pairs of terms is a nice feature, but hardly a step in the

Re: [PATCH 4/4] bisect: add the terms old/new

2015-06-10 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Somebody else did it like that is not a good justification. Especially when the previous code was not merged: the code wasn't finished. But I actually disagree with the fact that it was not the idea. The point of having the terms in

[PATCH 4/4] bisect: add the terms old/new

2015-06-08 Thread Antoine Delaite
When not looking for a regression during a bisect but for a fix or a change in another given property, it can be confusing to use 'good' and 'bad'. This patch introduce `git bisect new` and `git bisect old` as an alternative to 'bad' and good': the commits which have a certain property must be

Re: [PATCH 4/4] bisect: add the terms old/new

2015-06-08 Thread Junio C Hamano
Antoine Delaite antoine.dela...@ensimag.grenoble-inp.fr writes: When not looking for a regression during a bisect but for a fix or a change in another given property, it can be confusing to use 'good' and 'bad'. This patch introduce `git bisect new` and `git bisect old` as an alternative to