Re: [PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

Hey Eric, On Wed, Jun 8, 2016 at 11:23 PM, Eric Sunshine wrote: > On Wed, Jun 8, 2016 at 9:20 AM, Pranit Bauva wrote: >> On Wed, Jun 8, 2016 at 1:29 PM, Eric Sunshine >> wrote: >>> On Tue, Jun 7, 2016 at 4:54 PM, Pranit

Re: [PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

On Wed, Jun 8, 2016 at 9:20 AM, Pranit Bauva wrote: > On Wed, Jun 8, 2016 at 1:29 PM, Eric Sunshine wrote: >> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >>> + if (!file_exists(git_path_bisect_head())) { >>>

Re: [PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

On Wed, Jun 8, 2016 at 5:51 AM, Christian Couder wrote: > On Wed, Jun 8, 2016 at 9:59 AM, Eric Sunshine wrote: >>> + if (file_size(git_path_bisect_start()) < 1) { >> >> This doesn't even care about the size of the file, only if it >>

Re: [PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

Hey Eric, On Wed, Jun 8, 2016 at 1:29 PM, Eric Sunshine wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >> Reimplement `bisect_reset` shell function in C and add a `--bisect-reset` >> subcommand to `git bisect--helper` to call it

Re: [PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

On Wed, Jun 8, 2016 at 9:59 AM, Eric Sunshine wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >> Reimplement `bisect_reset` shell function in C and add a `--bisect-reset` >> subcommand to `git bisect--helper` to call it from

Re: [PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

On Wed, Jun 8, 2016 at 11:51 AM, Christian Couder wrote: > On Wed, Jun 8, 2016 at 9:59 AM, Eric Sunshine wrote: >> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >>> Reimplement `bisect_reset` shell function in C

Re: [PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: > Reimplement `bisect_reset` shell function in C and add a `--bisect-reset` > subcommand to `git bisect--helper` to call it from git-bisect.sh . > > Using `bisect_reset` subcommand is a temporary measure to port shell >

[PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

Reimplement `bisect_reset` shell function in C and add a `--bisect-reset` subcommand to `git bisect--helper` to call it from git-bisect.sh . Using `bisect_reset` subcommand is a temporary measure to port shell functions to C so as to use the existing test suite. As more functions are ported, this