Re: [PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces

2017-10-30 Thread Antoine Beaupré
On 2017-10-29 23:52:16, Eric Sunshine wrote: > On Sun, Oct 29, 2017 at 10:43 PM, Antoine Beaupré wrote: >> On 2017-10-29 15:49:28, Eric Sunshine wrote: >>> This may be problematic since get_mw_namespace_id() may return undef >>> rather than a number, in which case Perl will

Re: [PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces

2017-10-29 Thread Eric Sunshine
On Sun, Oct 29, 2017 at 10:43 PM, Antoine Beaupré wrote: > On 2017-10-29 15:49:28, Eric Sunshine wrote: >> This may be problematic since get_mw_namespace_id() may return undef >> rather than a number, in which case Perl will complain. > > Actually, get_mw_namespace_id()

Re: [PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces

2017-10-29 Thread Eric Sunshine
On Sun, Oct 29, 2017 at 10:11 PM, Antoine Beaupré wrote: > On 2017-10-29 15:49:28, Eric Sunshine wrote: >> On Sun, Oct 29, 2017 at 12:08 PM, Antoine Beaupré wrote: >>> +foreach my $local_namespace (sort @tracked_namespaces) { >>> +my

Re: [PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces

2017-10-29 Thread Antoine Beaupré
On 2017-10-29 15:49:28, Eric Sunshine wrote: [...] >> Reviewed-by: Antoine Beaupré >> Signed-off-by: Antoine Beaupré >> --- >> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl >> b/contrib/mw-to-git/git-remote-mediawiki.perl >> @@ -264,16 +264,27

Re: [PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces

2017-10-29 Thread Antoine Beaupré
On 2017-10-29 15:49:28, Eric Sunshine wrote: > On Sun, Oct 29, 2017 at 12:08 PM, Antoine Beaupré wrote: >> Subject: remote-mediawiki: allow using (Main) as a namespace and skip >> special namespaces > > This patch is more difficult to review than it perhaps ought to be >

Re: [PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces

2017-10-29 Thread Eric Sunshine
On Sun, Oct 29, 2017 at 12:08 PM, Antoine Beaupré wrote: > Subject: remote-mediawiki: allow using (Main) as a namespace and skip special > namespaces This patch is more difficult to review than it perhaps ought to be since it is making multiple unrelated changes. It's not

[PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces

2017-10-29 Thread Antoine Beaupré
Reviewed-by: Antoine Beaupré Signed-off-by: Antoine Beaupré --- contrib/mw-to-git/git-remote-mediawiki.perl | 31 +++-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl