Re: [PATCH 4/5] t/t5520: modify tests to reduce common code

2016-03-29 Thread Eric Sunshine
On Tue, Mar 29, 2016 at 9:29 AM, Mehul Jain wrote: > t/t5520: modify tests to reduce common code As this is indeed a patch, "modify" is implied. Perhaps: t5520: factor out common code > There exist three groups of tests which have repetitive lines of code. > >

Re: [PATCH 4/5] t/t5520: modify tests to reduce common code

2016-03-29 Thread Junio C Hamano
Mehul Jain writes: > There exist three groups of tests which have repetitive lines of code. > > Introduce two functions test_rebase_autostash() and > test_rebase_no_autostash() to reduce the number of lines. Also introduce > loops to futher reduce the current

[PATCH 4/5] t/t5520: modify tests to reduce common code

2016-03-29 Thread Mehul Jain
There exist three groups of tests which have repetitive lines of code. Introduce two functions test_rebase_autostash() and test_rebase_no_autostash() to reduce the number of lines. Also introduce loops to futher reduce the current implementation. Helped-by: Eric Sunshine