Re: [PATCH 4/5] trailer: reuse ignore_non_trailer() to ignore conflict lines

2014-11-09 Thread Christian Couder
From: Junio C Hamano gits...@pobox.com Subject: Re: [PATCH 4/5] trailer: reuse ignore_non_trailer() to ignore conflict lines Date: Fri, 07 Nov 2014 12:27:03 -0800 Christian Couder chrisc...@tuxfamily.org writes: * Copyright (c) 2013, 2014 Christian Couder chrisc...@tuxfamily.org

Re: [PATCH 4/5] trailer: reuse ignore_non_trailer() to ignore conflict lines

2014-11-09 Thread Junio C Hamano
Christian Couder chrisc...@tuxfamily.org writes: Yeah, it won't be as efficient as using only one strbuf and only byte oriented functions, and it looks much less manly too :-) But over time in Git we have developed a number of less efficient but quite clean abstractions like strbuf,

Re: [PATCH 4/5] trailer: reuse ignore_non_trailer() to ignore conflict lines

2014-11-09 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Christian Couder chrisc...@tuxfamily.org writes: Yeah, it won't be as efficient as using only one strbuf and only byte oriented functions, and it looks much less manly too :-) But over time in Git we have developed a number of less efficient but quite

Re: [PATCH 4/5] trailer: reuse ignore_non_trailer() to ignore conflict lines

2014-11-09 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Junio C Hamano gits...@pobox.com writes: Christian Couder chrisc...@tuxfamily.org writes: Yeah, it won't be as efficient as using only one strbuf and only byte oriented functions, and it looks much less manly too :-) But over time in Git we have

[PATCH 4/5] trailer: reuse ignore_non_trailer() to ignore conflict lines

2014-11-07 Thread Christian Couder
Make sure we look for trailers before any conflict line by reusing the ignore_non_trailer() function. Signed-off-by: Christian Couder chrisc...@tuxfamily.org --- t/t7513-interpret-trailers.sh | 2 ++ trailer.c | 25 ++--- 2 files changed, 20

Re: [PATCH 4/5] trailer: reuse ignore_non_trailer() to ignore conflict lines

2014-11-07 Thread Junio C Hamano
Christian Couder chrisc...@tuxfamily.org writes: * Copyright (c) 2013, 2014 Christian Couder chrisc...@tuxfamily.org @@ -791,14 +792,24 @@ static int process_input_file(struct strbuf **lines, struct trailer_item **in_tok_last) { int count = 0; - int