Re: [PATCH 4/5] wt-status: don't skip a magical number of characters blindly

2015-11-01 Thread Junio C Hamano
Junio C Hamano writes: >> diff --git a/wt-status.c b/wt-status.c >> index e206cc9..42ea15e 100644 >> --- a/wt-status.c >> +++ b/wt-status.c >> @@ -1656,7 +1656,7 @@ static void wt_shortstatus_print_tracking(struct >> wt_status *s) >> if (starts_with(branch_name, "refs/heads/")) >>

Re: [PATCH 4/5] wt-status: don't skip a magical number of characters blindly

2015-11-01 Thread Junio C Hamano
René Scharfe writes: > Use the variable branch_name, which already has "refs/heads/" removed, > instead of blindly advancing in the ->branch string by 11 bytes. This > is safer and less magical. > > Signed-off-by: Rene Scharfe > --- > wt-status.c | 2 +- > 1 file changed, 1 insertion(+), 1 del

[PATCH 4/5] wt-status: don't skip a magical number of characters blindly

2015-10-31 Thread René Scharfe
Use the variable branch_name, which already has "refs/heads/" removed, instead of blindly advancing in the ->branch string by 11 bytes. This is safer and less magical. Signed-off-by: Rene Scharfe --- wt-status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wt-status.c b/w