Re: [PATCH 4/6] completion: correct completion for format-patch

2013-06-02 Thread Ramkumar Ramachandra
Felipe Contreras wrote: > This breaks 'git format-patch master..'. Oh, ouch. > Moreover, this is a perfectly fine usage of 'git format-patch': > > % git format-patch --full-diff master..fc/remote/hg-next -- > contrib/remote-helpers/git-remote-bzr Never mind then. Drop this patch. -- To unsubscr

Re: [PATCH 4/6] completion: correct completion for format-patch

2013-06-02 Thread Felipe Contreras
On Sun, Jun 2, 2013 at 9:03 AM, Ramkumar Ramachandra wrote: > Currently, the completion for 'git format-patch' uses > __git_complete_revlist. Although this is technically correct, and you > can > > $ git format-patch master contrib > > where master is a ref and contrib is a pathspec, just like

[PATCH 4/6] completion: correct completion for format-patch

2013-06-02 Thread Ramkumar Ramachandra
Currently, the completion for 'git format-patch' uses __git_complete_revlist. Although this is technically correct, and you can $ git format-patch master contrib where master is a ref and contrib is a pathspec, just like in 'git log', the usage is unidiomatic and undocumented. 'git format-pat