On Fri, Aug 5, 2016 at 2:31 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> I thought about rolling it as a strict bugfix; but the bug is shaded by the
>> inverse bug in the helper, so the user would never see an issue.
>
> Ahh, OK, because the helper accepts "--reference" "--reference=foo
Stefan Beller writes:
> I thought about rolling it as a strict bugfix; but the bug is shaded by the
> inverse bug in the helper, so the user would never see an issue.
Ahh, OK, because the helper accepts "--reference" "--reference=foo"
as a OPT_STRING whose value happens to be "--reference=foo",
On Fri, Aug 5, 2016 at 2:06 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>>> - ${reference:+--reference "$reference"} \
>>> + ${reference:+"$reference"} \
>>
>> Note how this changed the API of the submodule--helper.
>> Currently we pass in --reference $referenc
Stefan Beller writes:
>> - ${reference:+--reference "$reference"} \
>> + ${reference:+"$reference"} \
>
> Note how this changed the API of the submodule--helper.
> Currently we pass in --reference $reference
> and $reference consists of the string "--reference" and the
> - ${reference:+--reference "$reference"} \
> + ${reference:+"$reference"} \
Note how this changed the API of the submodule--helper.
Currently we pass in --reference $reference
and $reference consists of the string "--reference" and the actual
reference. So it looked l
Allow the user to pass in multiple references to update_clone.
Currently this is only internal API, but once the shell script is
replaced by a C version, this is needed.
Signed-off-by: Stefan Beller
---
builtin/submodule--helper.c | 14 +-
git-submodule.sh| 2 +-
2 files
6 matches
Mail list logo