Re: [PATCH 4/7] get-tar-commit-id: prefer "!=" for read_in_full() error check

Jeff King wrote: > Suggested-by: Jonathan Nieder > Signed-off-by: Jeff King > --- > builtin/get-tar-commit-id.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Jonathan Nieder

[PATCH 4/7] get-tar-commit-id: prefer "!=" for read_in_full() error check

Comparing the result of read_in_full() using less-than is potentially dangerous, as discussed in 561598cfcf (read_pack_header: handle signed/unsigned comparison in read result, 2017-09-13). The instance in get-tar-commit-id is OK, because the HEADERSIZE macro expands to a signed integer. But if