[PATCH 4/8] diff.c: reorder arguments for emit_line_ws_markup

2018-08-13 Thread Stefan Beller
The order shall be all colors first, then the content, flags at the end. The colors are in the order of occurrence, i.e. first the color for the sign and then the color for the rest of the line. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano --- diff.c | 12 ++-- 1 file

Re: [PATCH 4/8] diff.c: reorder arguments for emit_line_ws_markup

2018-08-13 Thread Johannes Schindelin
Hi Stefan, On Fri, 10 Aug 2018, Stefan Beller wrote: > The order shall be all colors first, then the content, flags at the end. Okay. > The colors are in order. In order of what? Of the wavelength? (I agree that the order now makes more sense, and that the diff is correct.) Ciao, Dscho >

[PATCH 4/8] diff.c: reorder arguments for emit_line_ws_markup

2018-08-10 Thread Stefan Beller
The order shall be all colors first, then the content, flags at the end. The colors are in order. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano --- diff.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/diff.c b/diff.c index

[PATCH 4/8] diff.c: reorder arguments for emit_line_ws_markup

2018-07-30 Thread Stefan Beller
The order shall be all colors first, then the content, flags at the end. The colors are in order. Signed-off-by: Stefan Beller --- diff.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/diff.c b/diff.c index f7251c89cbb..8fd2171d808 100644 --- a/diff.c +++

[PATCH 4/8] diff.c: reorder arguments for emit_line_ws_markup

2018-07-27 Thread Stefan Beller
The order shall be all colors first, then the content, flags at the end. The colors are in order. Signed-off-by: Stefan Beller --- diff.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/diff.c b/diff.c index f7251c89cbb..8fd2171d808 100644 --- a/diff.c +++