Re: [PATCH 41/68] init: use strbufs to store paths

2015-10-04 Thread Jeff King
On Sun, Oct 04, 2015 at 08:31:31AM +0200, Torsten Bögershausen wrote: > > That is the original signature, before my sprintf series. I do not mind > > leaving that as-is, and simply cleaning up probe_utf8_pathname_composition > > by using a strbuf internally there. Though I have to wonder if it

Re: [PATCH 41/68] init: use strbufs to store paths

2015-10-04 Thread Torsten Bögershausen
On 2015-10-04 05.37, Jeff King wrote: > On Sat, Oct 03, 2015 at 11:12:13PM +0200, Torsten Bögershausen wrote: > >>> Hmph, Peff's quick-fix passed the original "CoNfIg" in directly >>> to probe_utf8_pathname_composition() without changing its signature. >> True, ( I was thinking that the test

Re: [PATCH 41/68] init: use strbufs to store paths

2015-10-03 Thread Torsten Bögershausen
On 03.10.15 18:54, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> On 30.09.15 02:23, Jeff King wrote: >>> On Tue, Sep 29, 2015 at 04:50:39PM -0700, Michael Blume wrote: >>> I see compile errors on my mac: >> >> This is my attempt, passing the test, but not

Re: [PATCH 41/68] init: use strbufs to store paths

2015-10-03 Thread Junio C Hamano
Torsten Bögershausen writes: > On 30.09.15 02:23, Jeff King wrote: >> On Tue, Sep 29, 2015 at 04:50:39PM -0700, Michael Blume wrote: >> >>> I see compile errors on my mac: >>> > > This is my attempt, passing the test, but not fully polished. Thanks. > diff --git

Re: [PATCH 41/68] init: use strbufs to store paths

2015-10-03 Thread Jeff King
On Sat, Oct 03, 2015 at 11:12:13PM +0200, Torsten Bögershausen wrote: > > Hmph, Peff's quick-fix passed the original "CoNfIg" in directly > > to probe_utf8_pathname_composition() without changing its signature. > True, ( I was thinking that the test did only work on case insensitive FS). > We

Re: [PATCH 41/68] init: use strbufs to store paths

2015-10-02 Thread Torsten Bögershausen
On 10/01/2015 04:51 AM, Jeff King wrote: On Wed, Sep 30, 2015 at 01:00:56PM -0700, Junio C Hamano wrote: Wow, my patch isn't even close to reasonable. I didn't realize because we do not compile this code at all for non-Mac platforms. Sorry. Perhaps the way we completely stub out the platform

Re: [PATCH 41/68] init: use strbufs to store paths

2015-10-02 Thread Jeff King
On Fri, Oct 02, 2015 at 08:00:24AM +0200, Torsten Bögershausen wrote: > Peff, are you planing a re-roll ? > Or. Junio, do you plan to fix it ? > Or should I send a patch on top of pu ? I am on vacation, so I am hoping that somebody on OS X can confirm that the patch that I sent earlier does

Re: [PATCH 41/68] init: use strbufs to store paths

2015-10-02 Thread Torsten Bögershausen
On 30.09.15 02:23, Jeff King wrote: > On Tue, Sep 29, 2015 at 04:50:39PM -0700, Michael Blume wrote: > >> I see compile errors on my mac: >> This is my attempt, passing the test, but not fully polished. diff --git a/builtin/init-db.c b/builtin/init-db.c index 89f2c05..60b559c 100644 ---

Re: [PATCH 41/68] init: use strbufs to store paths

2015-09-30 Thread Junio C Hamano
Jeff King writes: > On Tue, Sep 29, 2015 at 04:50:39PM -0700, Michael Blume wrote: > >> I see compile errors on my mac: >> >> First a whole bunch of >> >> ./compat/precompose_utf8.h:30:45: warning: declaration of 'struct >> strbuf' will not be visible outside of this function

Re: [PATCH 41/68] init: use strbufs to store paths

2015-09-30 Thread Jeff King
On Wed, Sep 30, 2015 at 01:00:56PM -0700, Junio C Hamano wrote: > > Wow, my patch isn't even close to reasonable. I didn't realize because > > we do not compile this code at all for non-Mac platforms. Sorry. > > Perhaps the way we completely stub out the platform specific helpers > contributes

Re: [PATCH 41/68] init: use strbufs to store paths

2015-09-29 Thread Michael Blume
On Thu, Sep 24, 2015 at 2:07 PM, Jeff King wrote: > The init code predates strbufs, and uses PATH_MAX-sized > buffers along with many manual checks on intermediate sizes > (some of which make magic assumptions, such as that init > will not create a path inside .git longer than 50 >

Re: [PATCH 41/68] init: use strbufs to store paths

2015-09-29 Thread Jeff King
On Tue, Sep 29, 2015 at 04:50:39PM -0700, Michael Blume wrote: > I see compile errors on my mac: > > First a whole bunch of > > ./compat/precompose_utf8.h:30:45: warning: declaration of 'struct > strbuf' will not be visible outside of this function [-Wvisibility] > void

[PATCH 41/68] init: use strbufs to store paths

2015-09-24 Thread Jeff King
The init code predates strbufs, and uses PATH_MAX-sized buffers along with many manual checks on intermediate sizes (some of which make magic assumptions, such as that init will not create a path inside .git longer than 50 characters). We can simplify this greatly by using strbufs, which drops