Re: [PATCH 44/44] packfile: keep prepare_packed_git() private

2018-03-21 Thread Brandon Williams
On 03/03, Nguyễn Thái Ngọc Duy wrote: > The reason callers have to call this is to make sure either packed_git > or packed_git_mru pointers are initialized since we don't do that by > default. Sometimes it's hard to see this connection between where the > function is called and where packed_git

Re: [PATCH 44/44] packfile: keep prepare_packed_git() private

2018-03-19 Thread Jonathan Tan
On Sat, 3 Mar 2018 18:36:37 +0700 Nguyễn Thái Ngọc Duy wrote: > The reason callers have to call this is to make sure either packed_git > or packed_git_mru pointers are initialized since we don't do that by > default. Sometimes it's hard to see this connection between where

[PATCH 44/44] packfile: keep prepare_packed_git() private

2018-03-03 Thread Nguyễn Thái Ngọc Duy
The reason callers have to call this is to make sure either packed_git or packed_git_mru pointers are initialized since we don't do that by default. Sometimes it's hard to see this connection between where the function is called and where packed_git pointer is used (sometimes in separate