Re: [PATCH 5/5] builtin/config: introduce `color` type specifier

2018-04-26 Thread Taylor Blau
On Thu, Apr 26, 2018 at 02:32:54PM +0900, Junio C Hamano wrote: > Taylor Blau writes: > > > diff --git a/builtin/config.c b/builtin/config.c > > index d7acf912cd..ec5c11293b 100644 > > --- a/builtin/config.c > > +++ b/builtin/config.c > > @@ -61,6 +61,7 @@ static int

Re: [PATCH 5/5] builtin/config: introduce `color` type specifier

2018-04-25 Thread Junio C Hamano
Taylor Blau writes: > diff --git a/builtin/config.c b/builtin/config.c > index d7acf912cd..ec5c11293b 100644 > --- a/builtin/config.c > +++ b/builtin/config.c > @@ -61,6 +61,7 @@ static int show_origin; > #define TYPE_BOOL_OR_INT 3 > #define TYPE_PATH4 >

[PATCH 5/5] builtin/config: introduce `color` type specifier

2018-04-25 Thread Taylor Blau
As of this commit, the canonical way to retreive an ANSI-compatible color escape sequence from a configuration file is with the `--get-color` action. This is to allow Git to "fall back" on a default value for the color should the given section not exist in the specified configuration(s). With