Re: [PATCH 5/5] refspec.c: use rhs in parse_refspec instead of potentially uninitialized item->dst

On Thu, May 31, 2018 at 7:46 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Perhaps a better fisx is to explicitly assign NULL to item->dst when >> we see there is no right-hand-side. > > -- >8 -- > Subject: [PATCH] refspec-api: avoid uninitialized field in refspec item > > When

Re: [PATCH 5/5] refspec.c: use rhs in parse_refspec instead of potentially uninitialized item->dst

Junio C Hamano writes: > Perhaps a better fisx is to explicitly assign NULL to item->dst when > we see there is no right-hand-side. -- >8 -- Subject: [PATCH] refspec-api: avoid uninitialized field in refspec item When parse_refspec() function was created at 3eec3700 ("refspec: factor out

Re: [PATCH 5/5] refspec.c: use rhs in parse_refspec instead of potentially uninitialized item->dst

Stefan Beller writes: > 'item->dst' has not been assigned if '!rhs' is true. As the caller is allowed > to pass in uninitialized > memory (we don't assume 'item' was zeroed out before calling), this fixes an > access to > uninitialized memory. Did I miss the other 4 patches that this might

[PATCH 5/5] refspec.c: use rhs in parse_refspec instead of potentially uninitialized item->dst

'item->dst' has not been assigned if '!rhs' is true. As the caller is allowed to pass in uninitialized memory (we don't assume 'item' was zeroed out before calling), this fixes an access to uninitialized memory. Signed-off-by: Stefan Beller --- applies on bw/refspec-api refspec.c | 2 +- 1