Re: [PATCH 5/5] submodule: fixup nested submodules after moving the submodule

2018-03-27 Thread Stefan Beller
On Tue, Mar 27, 2018 at 5:07 PM, Jonathan Tan wrote: > s/submoduled/submodules > s/superprojects/superproject's/ > s/and // > > s/force/forcing/ All wording fixed. >> + sub_path = sub_worktree + strlen(super_worktree) + 1; >> + >> + if (repo_submodule_init(,

Re: [PATCH 5/5] submodule: fixup nested submodules after moving the submodule

2018-03-27 Thread Jonathan Tan
On Tue, 27 Mar 2018 14:39:18 -0700 Stefan Beller wrote: > connect_work_tree_and_git_dir is used to connect a submodule worktree with > its git directory and vice versa after events that require a reconnection > such as moving around the working tree. As submodules can have

Re: [PATCH 5/5] submodule: fixup nested submodules after moving the submodule

2018-03-27 Thread Brandon Williams
On 03/27, Stefan Beller wrote: > connect_work_tree_and_git_dir is used to connect a submodule worktree with > its git directory and vice versa after events that require a reconnection > such as moving around the working tree. As submodules can have nested > submoduled themselves, we'd also want to

[PATCH 5/5] submodule: fixup nested submodules after moving the submodule

2018-03-27 Thread Stefan Beller
connect_work_tree_and_git_dir is used to connect a submodule worktree with its git directory and vice versa after events that require a reconnection such as moving around the working tree. As submodules can have nested submoduled themselves, we'd also want to fix the nested submodules when asked