Re: [PATCH 5/5] submodule: port submodule subcommand 'foreach' from shell to C

On Wed, 2 May 2018 17:53:58 -0700 Stefan Beller wrote: > + argv_array_pushf(, "path=%s; %s", > + path, info->argv[0]); Do we need to quote the path here? (For example, what if path has a quotation mark?) Also, would it be useful to

Re: [PATCH 5/5] submodule: port submodule subcommand 'foreach' from shell to C

On Wed, May 2, 2018 at 5:53 PM, Stefan Beller wrote: > +struct cb_foreach { > + char *toplevel; ... > + OPT_STRING(0, "toplevel", , N_("path"), > + N_("path from the top level of the invocation")), This is a leftover from my

[PATCH 5/5] submodule: port submodule subcommand 'foreach' from shell to C

From: Prathamesh Chavan This aims to make git-submodule foreach a builtin. 'foreach' is ported to the submodule--helper, and submodule--helper is called from git-submodule.sh. Helped-by: Brandon Williams Mentored-by: Christian Couder