Re: [PATCH 5/6] Git.pm: teach ident to query explicitness

Jeff King wrote: git var recently learned to report on whether an ident we fetch from it was configured explicitly or implicitly. Let's make that information available to callers of the ident function. Sounds sensible. Quick nits: [...] --- a/perl/Git.pm +++ b/perl/Git.pm @@ -737,7

Re: [PATCH 5/6] Git.pm: teach ident to query explicitness

On Wed, Nov 14, 2012 at 09:12:13AM -0800, Jonathan Nieder wrote: --- a/perl/Git.pm +++ b/perl/Git.pm @@ -737,7 +737,7 @@ sub remote_refs { } -=item ident ( TYPE | IDENTSTR ) +=item ident ( TYPE | IDENTSTR [, options] ) =item ident_person ( TYPE | IDENTSTR | IDENTARRAY

[PATCH 5/6] Git.pm: teach ident to query explicitness

git var recently learned to report on whether an ident we fetch from it was configured explicitly or implicitly. Let's make that information available to callers of the ident function. Because evaluating ident in an array versus scalar context already has a meaning, we cannot return our extra

Re: [PATCH 5/6] Git.pm: teach ident to query explicitness

On Tue, Nov 13, 2012 at 09:23:00AM -0800, Matt Kraai wrote: Minor nits: On Tue, Nov 13, 2012 at 11:53:20AM -0500, Jeff King wrote: @@ -750,6 +750,10 @@ and either returns it as a scalar string or as an array with the fields parsed. Alternatively, it can take a prepared ident string