Jeff King writes:
> Agreed. Maybe the simplest thing would be to have grep_config fill in a
> "static struct grep_opt grep_defaults", and then memcpy that into place
> during init_revisions?
Yes, I was doing that for a bit last night, but then realized that
the grep_config() should be split into
On Thu, Oct 04, 2012 at 09:16:14PM -0700, Junio C Hamano wrote:
> Junio C Hamano writes:
>
> > So we would need to do something like:
> >
> > - call git_log_config() first to let diff_context_default
> > updated from the configuration as before. find the values of
> > grep.* def
Junio C Hamano writes:
> So we would need to do something like:
>
> - call git_log_config() first to let diff_context_default
> updated from the configuration as before. find the values of
> grep.* defaults at the same time, but stash it away in a
> separate "struct grep_op
Junio C Hamano writes:
> Call init_revisions() first to prepare the revision traversal
> parameters and pass it to git_log_config(), so that necessary bits
> in the traversal parameters can be tweaked before we call the
> command line parsing infrastructure setup_revisions() from
> the cmd_log_in
Call init_revisions() first to prepare the revision traversal
parameters and pass it to git_log_config(), so that necessary bits
in the traversal parameters can be tweaked before we call the
command line parsing infrastructure setup_revisions() from
the cmd_log_init_finish() function.
Signed-off-b
5 matches
Mail list logo
