[PATCH 5/8] combine-diff: move show_log_first logic/action out of paths scanning

2014-02-03 Thread Kirill Smelkov
Judging from sample outputs and tests nothing changes in diff -c output, and this change will help later patches, when we'll be refactoring paths scanning into its own function with several variants - the show_log_first logic / code will stay common to all of them. NOTE: only now we have to take

Re: [PATCH 5/8] combine-diff: move show_log_first logic/action out of paths scanning

2014-02-03 Thread Junio C Hamano
Kirill Smelkov k...@mns.spb.ru writes: Judging from sample outputs and tests nothing changes in diff -c output, Yuck. I do not think the processing done inside the loop for the first path (i.e. i==0) before we call show_log(rev) affects what that called show_log(rev) does, so it probably is a