Re: [PATCH 5/8] commit-graph: not compatible with replace objects

2018-07-29 Thread Jakub Narebski
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > Create new method commit_graph_compatible(r) to check if a given > repository r is compatible with the commit-graph feature. Fill the > method with a check to see if replace-objects exist. All right, looks sensible. Did you

Re: [PATCH 5/8] commit-graph: not compatible with replace objects

2018-07-20 Thread Derrick Stolee
On 7/20/2018 12:49 PM, Stefan Beller wrote: Thanks, Peff, for improving the check_replace_refs interaction [1]. Since this series now has two dependencies (including Stefan's ref-store fix [2] that I had included in my v1), I'll let those topics settle before I send a new v2. FYI: I have not

Re: [PATCH 5/8] commit-graph: not compatible with replace objects

2018-07-20 Thread Stefan Beller
> Thanks, Peff, for improving the check_replace_refs interaction [1]. > > Since this series now has two dependencies (including Stefan's ref-store > fix [2] that I had included in my v1), I'll let those topics settle > before I send a new v2. FYI: I have not been working on, nor plan to work on

Re: [PATCH 5/8] commit-graph: not compatible with replace objects

2018-07-20 Thread Derrick Stolee
On 7/18/2018 3:52 PM, Derrick Stolee wrote: On 7/18/2018 3:46 PM, Jeff King wrote: On Wed, Jul 18, 2018 at 08:15:41AM -0700, Derrick Stolee via GitGitGadget wrote: From: Derrick Stolee Create new method commit_graph_compatible(r) to check if a given repository r is compatible with the

Re: [PATCH 5/8] commit-graph: not compatible with replace objects

2018-07-18 Thread Derrick Stolee
On 7/18/2018 3:46 PM, Jeff King wrote: On Wed, Jul 18, 2018 at 08:15:41AM -0700, Derrick Stolee via GitGitGadget wrote: From: Derrick Stolee Create new method commit_graph_compatible(r) to check if a given repository r is compatible with the commit-graph feature. Fill the method with a check

Re: [PATCH 5/8] commit-graph: not compatible with replace objects

2018-07-18 Thread Jeff King
On Wed, Jul 18, 2018 at 03:46:57PM -0400, Jeff King wrote: > On Wed, Jul 18, 2018 at 08:15:41AM -0700, Derrick Stolee via GitGitGadget > wrote: > > > From: Derrick Stolee > > > > Create new method commit_graph_compatible(r) to check if a given > > repository r is compatible with the

Re: [PATCH 5/8] commit-graph: not compatible with replace objects

2018-07-18 Thread Jeff King
On Wed, Jul 18, 2018 at 08:15:41AM -0700, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > Create new method commit_graph_compatible(r) to check if a given > repository r is compatible with the commit-graph feature. Fill the > method with a check to see if replace-objects

[PATCH 5/8] commit-graph: not compatible with replace objects

2018-07-18 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee Create new method commit_graph_compatible(r) to check if a given repository r is compatible with the commit-graph feature. Fill the method with a check to see if replace-objects exist. Test this interaction succeeds, including ignoring an existing commit-graph and failing to