[PATCH 5/8] diff.c: add set_sign to emit_line_0

2018-08-13 Thread Stefan Beller
Split the meaning of the `set` parameter that is passed to emit_line_0()` to separate between the color of the "sign" (i.e. the diff marker '+', '-' or ' ' that is passed in as the `first` parameter) and the color of the rest of the line. This changes the meaning of the `set` parameter to no

Re: [PATCH 5/8] diff.c: add set_sign to emit_line_0

2018-08-13 Thread Stefan Beller
On Mon, Aug 13, 2018 at 5:15 AM Johannes Schindelin wrote: > > Hi Stefan, > > On Fri, 10 Aug 2018, Stefan Beller wrote: > > > For now just change the signature, we'll reason about the actual > > change in a follow up patch. > > > > Pass 'set_sign' (which is output before the sign) and 'set' which

Re: [PATCH 5/8] diff.c: add set_sign to emit_line_0

2018-08-13 Thread Johannes Schindelin
Hi Stefan, On Fri, 10 Aug 2018, Stefan Beller wrote: > For now just change the signature, we'll reason about the actual > change in a follow up patch. > > Pass 'set_sign' (which is output before the sign) and 'set' which > controls the color after the first character. Hence, promote any >

[PATCH 5/8] diff.c: add set_sign to emit_line_0

2018-08-10 Thread Stefan Beller
For now just change the signature, we'll reason about the actual change in a follow up patch. Pass 'set_sign' (which is output before the sign) and 'set' which controls the color after the first character. Hence, promote any 'set's to 'set_sign' as we want to have color before the sign for now.

[PATCH 5/8] diff.c: add set_sign to emit_line_0

2018-07-30 Thread Stefan Beller
For now just change the signature, we'll reason about the actual change in a follow up patch. Pass 'set_sign' (which is output before the sign) and 'set' which controls the color after the first character. Hence, promote any 'set's to 'set_sign' as we want to have color before the sign for now.

Re: [PATCH 5/8] diff.c: add set_sign to emit_line_0

2018-07-28 Thread Eric Sunshine
On Fri, Jul 27, 2018 at 11:05 PM Stefan Beller wrote: > For now just change the signature, we'll reason about the actual > change in a follow up patch. > > Pass set_sign (which is output before the sign) and set that is setting > the color after the sign. Hence, promote any 'set's to set_sign as

[PATCH 5/8] diff.c: add set_sign to emit_line_0

2018-07-27 Thread Stefan Beller
For now just change the signature, we'll reason about the actual change in a follow up patch. Pass set_sign (which is output before the sign) and set that is setting the color after the sign. Hence, promote any 'set's to set_sign as we want to have color before the sign for now. Signed-off-by: