Re: [PATCH 6/6] Document some functions defined in object.c

Nicolas, thanks for the very fast feedback! On 02/21/2014 06:33 PM, Nicolas Pitre wrote: On Fri, 21 Feb 2014, Michael Haggerty wrote: Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Minor nits below. --- object.c | 23 ++- object.h | 7 +++ 2 files

Re: [PATCH 6/6] Document some functions defined in object.c

Michael Haggerty mhag...@alum.mit.edu writes: Contrariwise, I thought about it again and believe that it *is* important for the docstring to mention explicitly that the return value is architecture-dependent As it gives an internal hash value which should not leak to the outside world (e.g.

[PATCH 6/6] Document some functions defined in object.c

Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- object.c | 23 ++- object.h | 7 +++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/object.c b/object.c index 584f7ac..c34e225 100644 --- a/object.c +++ b/object.c @@ -43,14 +43,26 @@ int

Re: [PATCH 6/6] Document some functions defined in object.c

On Fri, 21 Feb 2014, Michael Haggerty wrote: Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Minor nits below. --- object.c | 23 ++- object.h | 7 +++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/object.c b/object.c index