Re: [PATCH 6/6] grep: make it clear i-t-a entries are ignored

2015-12-28 Thread Junio C Hamano
This one looks correct. I'll pick the obviously correct pieces (1, 2, and 6) from this series, as they are pretty-much independent, and discard the rest for now. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More

[PATCH 6/6] grep: make it clear i-t-a entries are ignored

2015-12-26 Thread Nguyễn Thái Ngọc Duy
The expression "!S_ISREG(ce)" covers i-t-a entries as well because ce->ce_mode would be zero then. I could make a comment saying that, but it's probably better just to comment with code, in case i-t-a entry content changes in future. Signed-off-by: Nguyễn Thái Ngọc Duy ---