Re: [PATCH 6/6] send-email: do not prompt for explicit repo ident

2012-11-14 Thread Jonathan Nieder
Jeff King wrote: If git-send-email is configured with sendemail.from, we will not prompt the user for the From address of the emails. If it is not configured, we prompt the user, but provide the repo author or committer as a default. Even though we probably have a sensible value for the

Re: [PATCH 6/6] send-email: do not prompt for explicit repo ident

2012-11-14 Thread Jeff King
On Wed, Nov 14, 2012 at 09:18:27AM -0800, Jonathan Nieder wrote: The test scripts need to be adjusted to not expect a prompt for the sender, since they always have the author explicitly defined in the environment. Unfortunately, we cannot reliably test that prompting still happens in the

Re: [PATCH 6/6] send-email: do not prompt for explicit repo ident

2012-11-14 Thread Jeff King
On Wed, Nov 14, 2012 at 12:05:05PM -0800, Jeff King wrote: When someone writes such a test, I think it could check that git either prompts or writes a message advising to configure the user email, no? Waiting until later for that seems fine to me, though. Yes. The problem is that the

[PATCH 6/6] send-email: do not prompt for explicit repo ident

2012-11-13 Thread Jeff King
If git-send-email is configured with sendemail.from, we will not prompt the user for the From address of the emails. If it is not configured, we prompt the user, but provide the repo author or committer as a default. Even though we probably have a sensible value for the default, the prompt is a